Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update collect-styles.js to use ?inline to get the css during ssr #427

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

nksaraf
Copy link
Owner

@nksaraf nksaraf commented Dec 4, 2024

Because of this fix, vitejs/vite#17922, our way of importing css as js modules with default exports with css text, stopped working.

We are expected to use ?inline query to get the desired format, so this fixes that

Copy link

codesandbox bot commented Dec 4, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

changeset-bot bot commented Dec 4, 2024

⚠️ No Changeset found

Latest commit: 1ac2df3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vinxi-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 10:09pm

@nksaraf nksaraf merged commit 034b650 into main Dec 4, 2024
14 checks passed
Copy link

pkg-pr-new bot commented Dec 4, 2024

Open in Stackblitz

@vinxi/deno-doc

npm i https://pkg.pr.new/@vinxi/deno-doc@427

vinxi

npm i https://pkg.pr.new/vinxi@427

@vinxi/plugin-directives

npm i https://pkg.pr.new/@vinxi/plugin-directives@427

@vinxi/doc

npm i https://pkg.pr.new/@vinxi/doc@427

@vinxi/openapi

npm i https://pkg.pr.new/@vinxi/openapi@427

@vinxi/plugin-mdx

npm i https://pkg.pr.new/@vinxi/plugin-mdx@427

@vinxi/react

npm i https://pkg.pr.new/@vinxi/react@427

@vinxi/react-server

npm i https://pkg.pr.new/@vinxi/react-server@427

@vinxi/router

npm i https://pkg.pr.new/@vinxi/router@427

@vinxi/server-components

npm i https://pkg.pr.new/@vinxi/server-components@427

@vinxi/server-functions

npm i https://pkg.pr.new/@vinxi/server-functions@427

@vinxi/solid

npm i https://pkg.pr.new/@vinxi/solid@427

commit: 1ac2df3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant