Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: server preset defined in app config not working #78

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

edivados
Copy link
Contributor

@edivados edivados commented Jan 2, 2024

solidjs/solid-start#1208

on build the cli determines the preset without checking the app config.

Oh... just noticed that for dev the preset is also determined in the cli. Should it be moved back to the cli for build?
But then you would have to do it again in createBuild to cover this I guess. 🤔

async build() {
const { createBuild } = await import("./build.js");
await withLogger({}, () => createBuild(app, {}));
},

Copy link

codesandbox bot commented Jan 2, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

changeset-bot bot commented Jan 2, 2024

🦋 Changeset detected

Latest commit: 8c87b24

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 28 packages
Name Type
vinxi Patch
@vinxi/plugin-directives Patch
@vinxi/react-server Patch
@vinxi/router Patch
@vinxi/server-components Patch
@vinxi/server-functions Patch
example-react-server Patch
app Patch
example-react-spa-basic Patch
react-spa-mdx Patch
react-spa-tanstack-router-app Patch
example-react-spa-tanstack-router-app Patch
react-ssr-basic-cloudflare Patch
react-ssr-basic Patch
react-ssr-tanstack-router-app Patch
react-ssr-wouter Patch
solid-spa-basic Patch
solid-ssr-basic Patch
example-ssr-solid-router Patch
example-vanilla-empty Patch
example-vanilla-partyroom Patch
example-vanilla-spa Patch
example-vanilla-stack Patch
example-vanilla-trpc Patch
test-react-rsc Patch
test-react-srv-fn Patch
react-ssr-test-fs Patch
test-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vinxi-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 4, 2024 7:44am

@edivados edivados changed the title fix: preset always node-server because of cli default fix: server preset not defined in app config not working Jan 2, 2024
@edivados edivados changed the title fix: server preset not defined in app config not working fix: server preset defined in app config not working Jan 2, 2024
@nksaraf nksaraf merged commit af9ba6c into nksaraf:main Jan 4, 2024
@edivados edivados deleted the fix-server-preset branch January 4, 2024 09:06
@nksaraf nksaraf mentioned this pull request Jan 4, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants