Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: local package import #10

Merged
merged 8 commits into from
Jan 23, 2021
Merged

Fix: local package import #10

merged 8 commits into from
Jan 23, 2021

Conversation

GewoonMaarten
Copy link
Contributor

@GewoonMaarten GewoonMaarten commented Jan 16, 2021 •
edited
Loading

Currently packages are not correctly imported, because they reference a local package which doesn't exist.

In addition I've grouped components that have a close relation to each other. Before you had to import the related packages like this:

import Stepper from  '@gemeente-denhaag/stepper/Stepper'
import Step from  '@gemeente-denhaag/step/Step'
import StepLabel from  '@gemeente-denhaag/steplabel/StepLabel'
import StepContent from  '@gemeente-denhaag/stepcontent/StepContent'

You can now import these packages with:

import Stepper, {
  Step,
  StepLabel,
  StepContent 
} from '@gemeente-denhaag/stepper'

This pull request is related to issue #5.

@GewoonMaarten
Fix local package import
d41332f
@GewoonMaarten
Add main and module to every package.json
f80781e 
This will simplify the imports. Instead of
'@gemeente-denhaag/stepper/Stepper' you can do
'@gemeente-denhaag/stepper'
@GewoonMaarten
Add export to grouped components
692e619 
I assumed that components which had dependencies on other components and
did not import them were meant to group them. So I added an export for
every such component.
@GewoonMaarten
Removed tabscrollbutton from tab
e86fcad
@GewoonMaarten
Add index.tsx to group components
1eb0104
@GewoonMaarten
Add pickers back to package.json
cf1f141
@GewoonMaarten
Update imports in badge
7092026
@GewoonMaarten GewoonMaarten changed the title [Draft] Fix local package import Fix local package import Jan 16, 2021
@GewoonMaarten GewoonMaarten changed the title Fix local package import Fix: local package import Jan 23, 2021
DanielvanVliet
DanielvanVliet approved these changes Jan 23, 2021
View reviewed changes
Copy link
Contributor

@DanielvanVliet DanielvanVliet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@GewoonMaarten GewoonMaarten self-assigned this Jan 23, 2021
@GewoonMaarten GewoonMaarten linked an issue Jan 23, 2021 that may be closed by this pull request
Make component library available for other projects #5
Closed
4 tasks
@GewoonMaarten GewoonMaarten merged commit 7f30d3e into development Jan 23, 2021
@GewoonMaarten GewoonMaarten deleted the fix/npm-packages-#5 branch January 23, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joostvanviegen joostvanviegen joostvanviegen approved these changes

@DanielvanVliet DanielvanVliet DanielvanVliet approved these changes

Assignees

@GewoonMaarten GewoonMaarten

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make component library available for other projects
3 participants
@GewoonMaarten @joostvanviegen @DanielvanVliet