Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tabindex 0 on code block component #1726

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Conversation

hidde
Copy link
Member

@hidde hidde commented Nov 18, 2024

fixes #1725

Copy link

vercel bot commented Nov 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
documentatie ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 3:32pm

@Robbert Robbert merged commit 1c2a4ec into main Nov 18, 2024
7 checks passed
@Robbert Robbert deleted the fix/fix-scrollable-code-block branch November 18, 2024 21:43
@Robbert
Copy link
Member

Robbert commented Nov 18, 2024

Oops, heb 'm al gemerged. We kunnen reverten als @MarjonBakker twijfelt of oneens is

@MarjonBakker
Copy link
Contributor

@Robbert @hidde alleen een tabindex="0" is denk ik niet optimaal. Ik zou het dan graag uitgebreid zien met role="region" en aria-label="codevoorbeeld". Zodoende krijgt het element een passende rol en naam. Bijkomend voordeel is dat dit dan een container is die je in bijvoorbeeld NVDA snel kunt skippen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maak codevoorbeelden scrollbaar met toetsenbord
3 participants