Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Feedback op stap "Voeg de component toe aan een config" in het NLDS Community Stappenplan (#2021) #2022

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

eslook
Copy link
Contributor

@eslook eslook commented Feb 17, 2025

Closes #2021

@eslook eslook requested review from Robbert and matijs February 17, 2025 15:09
Copy link

vercel bot commented Feb 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
documentatie ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 7:45am

@eslook eslook self-assigned this Feb 17, 2025
@eslook eslook enabled auto-merge (rebase) February 17, 2025 15:10
Importeer de design tokens van de organisatie in `/packages/storybook/config/preview.ts`:

```tsx
import "organisatie-package/design-tokens/dist/index.css";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeffreylauwers heb jij hier een mening over?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nee :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Als er een custom font is, dan moet die ook nog geïmporteerd worden. Kan wat mij betreft ook in een latere PR.

Importeer de design tokens van de organisatie in `/packages/storybook/config/preview.ts`:

```tsx
import "organisatie-package/design-tokens/dist/index.css";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import "organisatie-package/design-tokens/dist/index.css";
import "@example/organisatie-design-tokens/dist/index.css";

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bij het controleren van de preview.ts hiervoor, kwam ik het volgende tegen:

Een aantal maakt niet gebruik van "@nl-design-system-community/-design-tokens/", bijv:
import '@amsterdam/design-system-tokens/dist/index.theme.css';

Een aantal importeert vanuit de src ipv de dist:
import '@nl-design-system-community/nora-design-tokens/src/font.js';

Zijn beide expres?

Importeer de design tokens van de organisatie in `/packages/storybook/config/preview.ts`:

```tsx
import "organisatie-package/design-tokens/dist/index.css";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Als er een custom font is, dan moet die ook nog geïmporteerd worden. Kan wat mij betreft ook in een latere PR.

Robbert
Robbert previously approved these changes Feb 17, 2025
@eslook eslook disabled auto-merge February 17, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feedback op stap "Voeg de component toe aan een config" in het NLDS Community Stappenplan
4 participants