-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Feedback op stap "Voeg de component toe aan een config" in het NLDS Community Stappenplan (#2021) #2022
base: main
Are you sure you want to change the base?
Conversation
…NLDS Community Stappenplan (#2021)
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Importeer de design tokens van de organisatie in `/packages/storybook/config/preview.ts`: | ||
|
||
```tsx | ||
import "organisatie-package/design-tokens/dist/index.css"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeffreylauwers heb jij hier een mening over?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nee :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Als er een custom font is, dan moet die ook nog geïmporteerd worden. Kan wat mij betreft ook in een latere PR.
Importeer de design tokens van de organisatie in `/packages/storybook/config/preview.ts`: | ||
|
||
```tsx | ||
import "organisatie-package/design-tokens/dist/index.css"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import "organisatie-package/design-tokens/dist/index.css"; | |
import "@example/organisatie-design-tokens/dist/index.css"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bij het controleren van de preview.ts
hiervoor, kwam ik het volgende tegen:
Een aantal maakt niet gebruik van "@nl-design-system-community/-design-tokens/", bijv:
import '@amsterdam/design-system-tokens/dist/index.theme.css';
Een aantal importeert vanuit de src ipv de dist:
import '@nl-design-system-community/nora-design-tokens/src/font.js';
Zijn beide expres?
Importeer de design tokens van de organisatie in `/packages/storybook/config/preview.ts`: | ||
|
||
```tsx | ||
import "organisatie-package/design-tokens/dist/index.css"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Als er een custom font is, dan moet die ook nog geïmporteerd worden. Kan wat mij betreft ook in een latere PR.
|
Closes #2021