PR feedback improvements

nl-design-system · Nov 8, 2024 · dae7a70 · dae7a70
1 parent 9373198
commit dae7a70
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 11 deletions.
diff --git a/packages/components-react/src/select/Select.tsx b/packages/components-react/src/select/Select.tsx
@@ -1,12 +1,15 @@
 import {
-  Select as UtrechtSelect,
-  SelectOption as UtrechtSelectOption,
+  Select,
+  SelectOption,
   type SelectOptionProps as UtrechtSelectOptionProps,
   type SelectProps as UtrechtSelectProps,
 } from '@utrecht/component-library-react/dist/css-module';
 
 export type LuxSelectProps = UtrechtSelectProps;
 export type LuxSelectOptionProps = UtrechtSelectOptionProps;
 
-export const LuxSelect = UtrechtSelect;
-export const LuxSelectOption = UtrechtSelectOption;
+Select.displayName = 'LuxSelect';
+SelectOption.displayName = 'LuxSelectOption';
+
+export const LuxSelect = Select;
+export const LuxSelectOption = SelectOption;
diff --git a/packages/storybook/src/react-components/select/select.stories.tsx b/packages/storybook/src/react-components/select/select.stories.tsx
@@ -43,13 +43,11 @@ const SelectTemplate: Story = {
   args: {},
   render: ({ ...args }) => (
     <LuxSelect {...args}>
-      {selectOptions &&
-        selectOptions.length > 0 &&
-        selectOptions.map(({ label, value, disabled }, index) => (
-          <LuxSelectOption key={index} value={value} disabled={disabled}>
-            {label}
-          </LuxSelectOption>
-        ))}
+      {selectOptions.map(({ label, value, disabled }, index) => (
+        <LuxSelectOption key={index} value={value} disabled={disabled}>
+          {label}
+        </LuxSelectOption>
+      ))}
     </LuxSelect>
   ),
 };