Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heading group #282

Closed
11 of 12 tasks
AlineNap opened this issue Oct 7, 2024 · 2 comments · Fixed by #320
Closed
11 of 12 tasks

Heading group #282

AlineNap opened this issue Oct 7, 2024 · 2 comments · Fixed by #320
Assignees
Labels
new component Adding a new component to the library react Issue involving a ReactJS component

Comments

@AlineNap
Copy link
Contributor

AlineNap commented Oct 7, 2024

Omschrijving

Toont een combinatie van een titel en ondersteunende tekst.

De benodigde componenten:

Heading group van utrecht
Preheading van utrecht

Definition of ready

  • Code check op community component gedaan door lux devs
  • Stijling check op community component gedaan door Aline
  • [ ] Plan voor missende features of bugs van het community component beschreven in het ticket
  • Component tokens zijn beschikbaar
  • Ticket doorgenomen met Vlad & Mark

Definition of done

Component

  • Component is beschikbaar in de index
  • Design tokens worden gebruikt

Storybook

  • Playground story
  • States en properties stories
  • Korte beschrijving van het component
    • Wat doet het
    • Basis van het component (bijv Utrecht)
    • Aanpassingen en/of uitbreidingen
    • Relatie met andere componenten (bijv. Form field label en Form field)

Tests

  • Het component rendert
  • Aanpassingen en/of uitbreidingen werken (zie ook Testing components)
  • Visual regression test (door LUX)

Links


Is voor dit design:
Image

@AlineNap AlineNap converted this from a draft issue Oct 7, 2024
@AlineNap
Copy link
Contributor Author

AlineNap commented Oct 7, 2024

Zie vragen in de comments van Figma.


Ik heb dit besproken tijdens de design open hour van 8 oktober. Stap x van x is de pre heading, daarna komt de titel en de paragraph daaronder is geen onderdeel van de heading groep. Aan de token row-gap hadden meerdere designers behoefte aan.

@AlineNap
Copy link
Contributor Author

AlineNap commented Oct 9, 2024

We bereiden de utrecht heading group uit met row-gap zodat er spacing tussen de pre-heading en heading gezet kan worden. nl-design-system/utrecht#2549

@MrSkippy MrSkippy added new component Adding a new component to the library react Issue involving a ReactJS component labels Oct 9, 2024
AlineNap added a commit that referenced this issue Oct 14, 2024
# Contents

Nieuwe tokens: component utrecht pre heading

Voor de tickets #282 en
#283

## Checklist

<!-- Surround an item with double tildes `~~` to indicate that it does
not apply to this PR -->

- ~~[ ] New features/components and bugfixes are covered by tests~~
- [x] Changesets are created
- ~~[ ] Definition of Done is checked~~

---------

Co-authored-by: Jaap-Hein Wester <j.h.wester@setonix.nl>
@MrSkippy MrSkippy mentioned this issue Oct 17, 2024
13 tasks
@MMeijerink MMeijerink self-assigned this Oct 18, 2024
@MMeijerink MMeijerink linked a pull request Oct 25, 2024 that will close this issue
3 tasks
@github-project-automation github-project-automation bot moved this from In design review to Done in Lux React Components Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new component Adding a new component to the library react Issue involving a ReactJS component
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants