Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added RadioButton and RadioGroup components. #328

Merged
merged 13 commits into from
Nov 20, 2024
Merged

feat: added RadioButton and RadioGroup components. #328

merged 13 commits into from
Nov 20, 2024

Conversation

VladAfanasev
Copy link
Contributor

Contents

Checklist

  • New features/components and bugfixes are covered by tests
  • Changesets are created
  • Definition of Done is checked

@VladAfanasev VladAfanasev requested a review from MrSkippy November 4, 2024 14:20
@vercel Vercel
Copy link

vercel bot commented Nov 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lux ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 8:47am

This was linked to issues Nov 5, 2024
Radio button #317
Closed
Radio Group #288
Closed
@remypar5 remypar5 self-requested a review November 5, 2024 12:40
remypar5
remypar5 requested changes Nov 5, 2024
View reviewed changes
.changeset/mean-books-sleep.md Outdated Show resolved Hide resolved
packages/components-react/src/radio-button/RadioButton.tsx Outdated Show resolved Hide resolved
packages/components-react/src/radio-group/RadioGroup.css Outdated Show resolved Hide resolved
packages/components-react/src/radio-group/RadioGroup.css Outdated Show resolved Hide resolved
packages/components-react/src/radio-group/RadioGroup.tsx Outdated Show resolved Hide resolved
packages/components-react/src/radio-group/RadioGroup.tsx Outdated Show resolved Hide resolved
packages/components-react/src/radio-group/RadioGroup.tsx Outdated Show resolved Hide resolved
remypar5
remypar5 previously requested changes Nov 5, 2024
View reviewed changes
packages/components-react/src/radio-group/RadioGroup.tsx Outdated Show resolved Hide resolved
@remypar5 remypar5 self-assigned this Nov 6, 2024
@VladAfanasev @remypar5
Update .changeset/mean-books-sleep.md
0fde95f 
Co-authored-by: Remy Parzinski <remypar5@users.noreply.github.com>
@VladAfanasev VladAfanasev requested a review from remypar5 November 7, 2024 15:18
MrSkippy
MrSkippy requested changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@MrSkippy MrSkippy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ook ff de naamgeving aanpassen van de gereleateerde files.

packages/components-react/src/radio-button/RadioButton.tsx Show resolved Hide resolved
packages/components-react/src/radio-group/RadioGroup.tsx Outdated Show resolved Hide resolved
packages/components-react/src/radio-button/RadioButton.tsx Outdated Show resolved Hide resolved
@MrSkippy MrSkippy removed the request for review from remypar5 November 18, 2024 07:48
MrSkippy
MrSkippy previously approved these changes Nov 18, 2024
View reviewed changes
@MrSkippy MrSkippy requested review from remypar5 and removed request for remypar5 November 18, 2024 07:50
@MrSkippy MrSkippy dismissed remypar5’s stale review November 18, 2024 07:52

Issues are resolved or stale

@MrSkippy MrSkippy merged commit a2ce8bc into main Nov 20, 2024
12 checks passed
@MrSkippy MrSkippy deleted the react-component-radio-button branch November 20, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrSkippy MrSkippy MrSkippy approved these changes

@remypar5 remypar5 remypar5 left review comments

Assignees

@remypar5 remypar5

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Radio button Radio Group
3 participants
@VladAfanasev @remypar5 @MrSkippy