test(components-react): add visual baselines for alert & link #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
remypar5
commented
Dec 6, 2024
| import { LuxLink } from '@lux-design-system/components-react'; | ||
|
|
||
| export const VisualStates = () => ( | ||
| <div className="utrecht-document"> |
There was a problem hiding this comment.
Suggested change
| <div className="utrecht-document"> | |
| <> |
@MrSkippy Ik heb sterk het gevoel dat dit niet klopt. Mijns inziens zou je niet verplicht utrecht-document moeten gebruiken om mooie links te hebben. Wat jij?
There was a problem hiding this comment.
Bij de links wel, helaas. Er is geen font-token voor de link, het inherit van de parent component, vandaar.
AlineNap
reviewed
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contents
Voeg baselines voor visuele regressie tests toe voor de volgende componenten:
LuxAlertLuxLinkChecklist
Changesets are createdDefinition of Done is checked