Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to get the game to be runnable straight away on Godot 4.2 #16

Closed
wants to merge 3 commits into from

Conversation

xanmankey
Copy link
Contributor

So I added the bin directory with the built executables and removed them from the .gitignore; the project does work, but only on the second try. I'm not sure if the issue for that is with godot 4 or the plugin itself (from what I've seen at godotengine/godot#77007, it seems like the initial import process is causing a circular dependency on linux). Maybe a README could be added to the /game directory or a line mentioning the import issue and to just try closing and reopening the project after initial import

@nlaha
Copy link
Owner

nlaha commented Jan 29, 2024

The binary (.so, .dll, etc.) files are not included in the git history by design. Those are either generated by your compiler if building from source, or downloaded from the releases tab in GitHub. Because this extension is a C++ GDExtension, it will not work without the binary files, please check that you have the following files in /game/addons/godot_midi/bin:

libgdgodotmidi.linux.template_debug.x86_64.so
libgdgodotmidi.linux.template_release.x86_64.so

@xanmankey
Copy link
Contributor Author

Gotcha, in that case I'll close this. I was cloning the repo, no wonder it wasn't working.

@xanmankey xanmankey closed this Jan 29, 2024
@nlaha
Copy link
Owner

nlaha commented Jan 29, 2024

I have noticed a similar issue where the project loads before the midi file is actually imported. So I think you're on to something here. Restarting the editor seems to fix it, but I'm going to post an issue anyways: #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants