Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for S3 object version IDs #4

Closed
wants to merge 25 commits into from
Closed

add support for S3 object version IDs #4

wants to merge 25 commits into from

Conversation

nlangellier
Copy link
Owner

No description provided.

@nlangellier nlangellier mentioned this pull request May 20, 2023
Closed
nlangellier
nlangellier commented May 30, 2023
View reviewed changes
Copy link
Owner Author

@nlangellier nlangellier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So now the from_bucket_key and from_bucket_key_versionid methods have a lot fo duplicated lines of code. can you think of a way where one of the methods calls the other method in order to not have so much code duplication?

s3path.py Outdated Show resolved Hide resolved
@nlangellier
Copy link
Owner Author

closing because we took a different approach

@nlangellier nlangellier closed this Aug 4, 2023
@nlangellier nlangellier deleted the feature/s3_object_version_id_support branch August 4, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nlangellier @chnpenny