Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change text about notes placement in generated content if notes use fallback mechanism #99

Closed
josteinaj opened this issue Sep 29, 2017 · 4 comments
Closed

Change text about notes placement in generated content if notes use fallback mechanism #99

josteinaj opened this issue Sep 29, 2017 · 4 comments
Assignees
@bertfrees
Labels
Priority:3 - High

Comments

@josteinaj
Copy link
Member

depends on: brailleapps/dotify#200

see also: #26
@josteinaj
Copy link
Member Author

see: 6c8182a#diff-30bed55a41a1fc6670a9bb1b1923e573R631

bertfrees added a commit that referenced this issue Oct 18, 2017
@bertfrees
[mod-nlb] Fix CSS for notes
5742dc8 
incl. fallback mechanism, see #99
@bertfrees
Copy link
Collaborator

Fixed.

@josteinaj josteinaj assigned KariRudjord and unassigned bertfrees Oct 18, 2017
@KariRudjord
Copy link

KariRudjord commented Nov 17, 2017 •
edited
Loading

Now it works. Just a little detail to be fixed. The notes miss a headline when using fallback mechanisme.
It should be like job 1554 result:

  CCCCCCCCCCCCCCCCCCCCCCCCCCCCC 
            ,FOTNOTER           
  CCCCCCCCCCCCCCCCCCCCCCCCCCCCC 
                                
    ,#A ,DEN NORSKE AMBASSADEN  
      I ,ISLAMABAD3             
      2,SIKKERHET; <HT-         
      TP3//WWW'NORWAY'ORG'PK/>  
      ,NORSK/PAKISTAN/REISE/SIK 
      KERHET/#',U#DUS,EY_Z,,IX; 
      W' ,LESEDATO #BJ'JE'BJAE

Not like this

    ,#A ,DEN NORSKE AMBASSADEN  
      I ,ISLAMABAD3             
      2,SIKKERHET; <HT-         
      TP3//WWW'NORWAY'ORG'PK/>  
      ,NORSK/PAKISTAN/REISE/SIK 
      KERHET/#',U#DUS,EY_Z,,IX; 
      W' ,LESEDATO #BJ'JE'BJAE

@josteinaj josteinaj assigned bertfrees and unassigned KariRudjord Nov 20, 2017
@KariRudjord
Copy link

Works.

bertfrees added a commit that referenced this issue Oct 9, 2019
@bertfrees @kalaspuffar
Various changes to <evaluate/> (#99)
64728e7 
* Allow evaluation of "$volume" in volume transitions and in normal flow

* Allow <evaluate expression="$page"/>

i.e. don't require the variable to be wrapped in a "(round ...)" or "(format {0} ...)"

Better would be to completely remove ExpressionTools and resolve variables in ExpressionImpl.

* Don't collect id-to-volume mapping until pages have come out of SheetDataSource

Initially, for pages in the volume body, the id-to-volume mapping was
done in VolumeProvider, but since the previous commit it was done also
in PageSequenceBuilder#nextPage, so in two places.

For pages in pre-/post-content, the id-to-volume mapping was only done
in PageSequenceBuilder#nextPage.

This commit moves the logic to one place, in VolumeProvider. Apart
from simplifying the code, this also fixes an issue in the regression
test suite. I have no proper explanation for it.

* In VolumeProvider align nextBodyContents and updateVolumeContents methods more

* Be more strict about what is allowed in an expression

For example, don't allow "$foo" when the variable "foo" is not declared.

* Don't normalize space in evaluate expressions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bertfrees bertfrees

Labels
Priority:3 - High
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@josteinaj @bertfrees @KariRudjord