fix: backspace of initial values is working

Uses the fix described in a comment on issue #115 in the danvick repo. danvick/flutter_chips_input#115 flutter test passes
nlfiedler · Mar 15, 2023 · e90ee8b · e90ee8b
1 parent 6167650
commit e90ee8b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/example/lib/main.dart b/example/lib/main.dart
@@ -9,7 +9,7 @@ class MyApp extends StatelessWidget {
   @override
   Widget build(BuildContext context) {
     return MaterialApp(
-      title: 'Flutter Chips Input',
+      title: 'Flutter ChipsInput',
       theme: ThemeData(
         primarySwatch: Colors.blue,
       ),
@@ -43,7 +43,7 @@ class MyHomePageState extends State<MyHomePage> {
     ];
 
     return Scaffold(
-      appBar: AppBar(title: const Text('Flutter ChipsInput Example')),
+      appBar: AppBar(title: const Text('Flutter ChipsInput')),
       body: Padding(
         padding: const EdgeInsets.all(20),
         child: SingleChildScrollView(
@@ -55,6 +55,9 @@ class MyHomePageState extends State<MyHomePage> {
               ),
               ChipsInput(
                 key: _chipKey,
+                initialValue: const [
+                  AppProfile('John', 'john@flutter.io', 'man-3.png')
+                ],
                 textStyle: const TextStyle(
                   height: 1.5,
                   fontFamily: 'Roboto',

diff --git a/lib/src/chips_input.dart b/lib/src/chips_input.dart
@@ -138,11 +138,10 @@ class ChipsInputState<T> extends State<ChipsInput<T>> with TextInputClient {
         ?.where((r) => !_chips.contains(r))
         .toList(growable: false);
     _suggestionsBoxController = SuggestionsBoxController(context);
-
     _effectiveFocusNode.addListener(_handleFocusChanged);
     _nodeAttachment = _effectiveFocusNode.attach(context);
     _effectiveFocusNode.canRequestFocus = _canRequestFocus;
-
+    _updateTextInputState(replaceText: true);
     WidgetsBinding.instance.addPostFrameCallback((_) async {
       _initOverlayEntry();
       if (mounted && widget.autofocus) {
@@ -377,7 +376,6 @@ class ChipsInputState<T> extends State<ChipsInput<T>> with TextInputClient {
           ));
     }
     if (!kIsWeb) {
-      // hack for https://github.com/danvick/flutter_chips_input/issues/34
       _closeInputConnectionIfNeeded();
     }
     _textInputConnection ??= TextInput.attach(this, textInputConfiguration);
@@ -478,7 +476,6 @@ class ChipsInputState<T> extends State<ChipsInput<T>> with TextInputClient {
         if (event.runtimeType.toString() == 'RawKeyDownEvent' &&
             event.logicalKey == LogicalKeyboardKey.backspace &&
             str.isNotEmpty) {
-          // TODO: try just str.length here
           final sd = str.substring(0, str.length - 1);
           updateEditingValue(TextEditingValue(
               text: sd, selection: TextSelection.collapsed(offset: sd.length)));