Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.

Updated flags for StanHeaders 2.26 #30

Closed
wants to merge 3 commits into from
Closed

Updated flags for StanHeaders 2.26 #30

wants to merge 3 commits into from

Conversation

andrjohns
Copy link

This PR re-enables your package's compilation and linker flags for compatibility with future StanHeaders versions.

I've run the checking workflows on my own fork and all has passed, but let me know if anything breaks again and I'll chase it down

@mattfidler
Copy link
Member

The tests for this are actually run in rxode2, but I am changing this anyway.

Thanks for the heads up. I will incorporate the changes in the revision.

When is the stan release?

@andrjohns
Copy link
Author

When is the stan release?

We don't have a definite date unfortunately, but you can see the status of the downstream patching in this issue: stan-dev/rstan#1034

@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Base: 44.36% // Head: 44.36% // No change to project coverage 👍

Coverage data is based on head (20a9665) compared to base (346bbcb).
Patch has no changes to coverable lines.

❗ Current head 20a9665 differs from pull request most recent head a46acb7. Consider uploading reports for the commit a46acb7 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #30   +/-   ##
=======================================
  Coverage   44.36%   44.36%           
=======================================
  Files          51       51           
  Lines        9724     9724           
=======================================
  Hits         4314     4314           
  Misses       5410     5410           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mattfidler
Copy link
Member

This was integrated in a separate branch with a few small fixes. It should work

@mattfidler mattfidler closed this Feb 27, 2023
@andrjohns
Copy link
Author

Perfect, thanks!

@bgoodri
Copy link

bgoodri commented Mar 10, 2023

Same deal as with nlmixr2est

@mattfidler
Copy link
Member

1 week is a bit tight but I will attempt this.

The problem is the dependencies that need to be resubmitted and or changed.

I'm sure you understand.

@mattfidler
Copy link
Member

@billdenney Let me know if there is anything outstanding that really needs to make the large submission to CRAN.

I will be starting as soon as I run everything locally and do the estimation tests.

@billdenney
Copy link
Contributor

I'll need to check the current PRs to see if there's something that I want to make sure to get in those. I do want the "modify a model by replacing the function body" into rxode2, and that doesn't yet have a PR yet (in rxode2).

@mattfidler
Copy link
Member

The etTrans will be moving since it checks out so far. You will have to be quick, though and provide some use case (I don't follow it here).

@billdenney
Copy link
Contributor

I have nothing in rxode2parse that needs to be captured this round.

@bgoodri
Copy link

bgoodri commented Mar 11, 2023

Yes, we understand

@mattfidler
Copy link
Member

The nlmixr2 based dependencies are now updated.

@mattfidler
Copy link
Member

That is rxode2, nlmixr2est, and rxode2ll

@andrjohns
Copy link
Author

Great, much appreciated!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants