Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override query templates with flags #58

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Override query templates with flags #58

merged 2 commits into from
Aug 23, 2023

Conversation

johnerikhalse
Copy link
Contributor

Let command line flags for template and format have preference to definitions in stored queries

@trym-b
Copy link
Contributor

trym-b commented Aug 22, 2023

I am not sure I quite understand the original use-case that triggered this PR. If you do not mind, could you perhaps write something about why this change is needed?
I could not quite guess it from the commit message, but that could be because of my limited knowledge of this project and of go in general. So perhaps this is a chance for me to learn something new :)

@johnerikhalse johnerikhalse force-pushed the respect_flags branch 2 times, most recently from cd239e9 to 2055842 Compare August 23, 2023 03:50
@johnerikhalse johnerikhalse added the enhancement New feature or request label Aug 23, 2023
@johnerikhalse johnerikhalse merged commit 3af2885 into master Aug 23, 2023
@johnerikhalse johnerikhalse deleted the respect_flags branch August 23, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trym-b trym-b trym-b approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnerikhalse @trym-b