Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance with many threads #133

Merged
merged 1 commit into from
May 1, 2017
Merged

Conversation

304NotModified
Copy link
Member

@304NotModified 304NotModified added this to the Web.AspNetCore 4.4.0 + Web 4.4.1 milestone May 1, 2017
@codecov
Copy link

codecov bot commented May 1, 2017

Codecov Report

Merging #133 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #133   +/-   ##
=======================================
  Coverage   59.03%   59.03%           
=======================================
  Files          25       25           
  Lines         310      310           
  Branches       77       77           
=======================================
  Hits          183      183           
  Misses         91       91           
  Partials       36       36
Impacted Files Coverage Δ
...etCore/LayoutRenderers/AspNetLayoutRendererBase.cs 87.5% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fca141...f967e29. Read the comment docs.

@304NotModified 304NotModified merged commit 56ad4ef into master May 1, 2017
@304NotModified 304NotModified deleted the improve-performance branch May 1, 2017 20:34
@snakefoot
Copy link
Contributor

@304NotModified If the usage of ServiceLocator.ServiceProvider should be avoided. Then maybe these should also be fixed:

  • AspNetEnvironmentLayoutRenderer.cs
  • IISInstanceNameLayoutRenderer.cs

@304NotModified
Copy link
Member Author

thanks will check them!

@snakefoot
Copy link
Contributor

snakefoot commented May 3, 2017

@304NotModified Wondering if it would make sense also to add:

protected override void CloseLayoutRenderer()
{
   _httpContextAccessor = null;
   base.CloseLayoutRenderer();
}

@304NotModified
Copy link
Member Author

good idea! Added to #134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants