Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't return "const values" #15

Closed
tanadeau opened this issue Jan 6, 2015 · 1 comment
Closed

Don't return "const values" #15

tanadeau opened this issue Jan 6, 2015 · 1 comment
Labels
kind: bug

Comments

@tanadeau
Copy link

tanadeau commented Jan 6, 2015

In member functions like dump and type_name, return std::string instead const std::string. Returning const values cause unnecessary copies to occur.
@nlohmann
Copy link
Owner

nlohmann commented Jan 6, 2015

Thanks for the hint!

@cronnosli cronnosli mentioned this issue Oct 8, 2017
Closed
@bignmllc bignmllc mentioned this issue Dec 22, 2017
Closed
@cosmos33 cosmos33 mentioned this issue Apr 20, 2019
Closed
@bnadem bnadem mentioned this issue Oct 15, 2019
Closed
@Hoohya Hoohya mentioned this issue Jan 2, 2020
Closed
GerHobbelt pushed a commit to GerHobbelt/nlohmann-json that referenced this issue May 7, 2021
@sthagen
Merge pull request nlohmann#15 from nlohmann/develop
1f720b4 
Sync Fork from Upstream Repo
@nlohmann nlohmann mentioned this issue Apr 30, 2022
Closed
2 tasks
925316 pushed a commit to 925316/json that referenced this issue Sep 26, 2024
fix: remove weather and spoofing(nlohmann#15)
67acbfc 
keep name spoofing menu button(nlohmann#14)
add smooth self-aim(nlohmann#7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nlohmann @tanadeau