-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Since re2c is often ignored in pull requests, it may make sense to make a contributing.md file #175
Comments
Thanks @whackashoe for noting this. Each time I commented on pull requests, I thought about writing such a file, but I always forget afterward. It's good to have this on the list here now. I shall try to merge this with the FAQ (#163). |
I added some guidelines. Please tell me what you think! |
Looks good. There are a couple places under files to change bullet 1 where you use src.json.hpp instead of src/json.hpp. |
Ooops. I fixed it. |
This is a small thing but perhaps add something about testing under Valgrind as occasionally (as I found out to my surprise in pull request #183) it can yield different results to a vanilla run. |
Thanks for the feedback! |
Would save people a bit of time, plus could be useful for keeping code the same style and such too.
The text was updated successfully, but these errors were encountered: