Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON Comments (JSON 5) #2090

Closed
robiwano opened this issue May 7, 2020 · 1 comment
Closed

JSON Comments (JSON 5) #2090

robiwano opened this issue May 7, 2020 · 1 comment
Labels
kind: enhancement/improvement solution: duplicate the issue is a duplicate; refer to the linked issue instead solution: wontfix the issue will not be fixed (either it is impossible or deemed out of scope)

Comments

@robiwano
Copy link

robiwano commented May 7, 2020

  • Describe the feature in as much detail as possible.
    Simple, it would be great if this project would support JSON 5 (https://json5.org/), which has both comment support and doesn't choke on trailing commas.
@nlohmann
Copy link
Owner

nlohmann commented May 7, 2020

Duplicate of #348. Please see also https://github.com/nlohmann/json#comments-in-json.

@nlohmann nlohmann added solution: duplicate the issue is a duplicate; refer to the linked issue instead solution: wontfix the issue will not be fixed (either it is impossible or deemed out of scope) labels May 7, 2020
@nlohmann nlohmann closed this as completed May 7, 2020
@nlohmann nlohmann mentioned this issue Jun 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind: enhancement/improvement solution: duplicate the issue is a duplicate; refer to the linked issue instead solution: wontfix the issue will not be fixed (either it is impossible or deemed out of scope)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nlohmann @robiwano