Add option to ignore comments in parse/accept functions #2212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔖 Release itemThis issue/PR will be part of the next release of the library. This template helps preparing the release notes. Type
Description
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an option
ignore_commentsto theparseandacceptfamily that allows to ignore//and/* */style comments.PS: I still think there is a good reason JSON has no comment support. But it was by far the most popular request, and I understand that the lack of comments was a problem for a lot of folks that use JSON as configuration format. However, comments are still treated as parse error by default.
Closes #2061
Closes #1513
Closes #597
Closes #376
Closes #363
Closes #294
Related to #2090 #348 (comments only, no full JSON5 support).
Related to #311 (comments only, no JSON Schema support)