Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

natvis not updated to 3.11.3 #4340

Closed
1 of 2 tasks
RomanKhv opened this issue Apr 10, 2024 · 1 comment · Fixed by #4451
Closed
1 of 2 tasks

natvis not updated to 3.11.3 #4340

RomanKhv opened this issue Apr 10, 2024 · 1 comment · Fixed by #4451
Labels
kind: bug solution: proposed fix a fix for the issue has been proposed and waits for confirmation

Comments

@RomanKhv
Copy link

Description

In version 3.11.3 the underlying namespace seems to be nlohmann::json_abi_v3_11_3.
But nlohmann_json.natvis is still written for nlohmann::json_abi_v3_11_2.

Reproduction steps

Expected vs. actual results

In VS Debugger Watch window view for json object is not pretty-printed (visualizer is not applied)

Minimal code example

No response

Error messages

No response

Compiler and operating system

Visual Studio

Library version

3.11.3

Validation

@gregmarr
Copy link
Contributor

If you have Python installed, you can update it yourself using https://github.com/nlohmann/json/blob/master/tools/generate_natvis/generate_natvis.py

@nlohmann I guess executing this script should be added to the version update process.

@nlohmann nlohmann added this to the Release 3.11.4 milestone Sep 5, 2024
@nlohmann nlohmann added the solution: proposed fix a fix for the issue has been proposed and waits for confirmation label Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants