Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update natvis to reflect 3.11.3 and the current structure of basic_json #4451

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

gmyers18
Copy link
Contributor

@gmyers18 gmyers18 commented Sep 5, 2024

In #3901 the underlying structure of basic_json was altered to move m_type and m_value under an m_data field. This updates the natvis Jinja template to be consistent with this change. The template is rendered to produce nlohmann_json.natvis consistent with version 3.11.3.

fixes #4438
fixes #4340


Pull request checklist

Read the Contribution Guidelines for detailed information.

  • Changes are described in the pull request, or an existing issue is referenced.
  • The test suite compiles and runs without error.
  • Code coverage is 100%. Test cases can be added by editing the test suite.
  • The source code is amalgamated; that is, after making changes to the sources in the include/nlohmann directory, run make amalgamate to create the single-header files single_include/nlohmann/json.hpp and single_include/nlohmann/json_fwd.hpp. The whole process is described here.

…c_json.

In 5a1a575 the underlying structure of
basic_json was altered to move m_type and m_value under an m_data field.
This updates the nativ template to be consistent with this change.
@gmyers18 gmyers18 requested a review from nlohmann as a code owner September 5, 2024 17:02
@github-actions github-actions bot added the L label Sep 5, 2024
@nlohmann nlohmann added this to the Release 3.11.4 milestone Sep 5, 2024
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann merged commit b36f4c4 into nlohmann:develop Sep 5, 2024
3 checks passed
@nlohmann
Copy link
Owner

nlohmann commented Sep 5, 2024

Thanks a lot!

slowriot pushed a commit to slowriot/json that referenced this pull request Jan 10, 2025
…on (nlohmann#4451)

* Update natvis Jinja template to reflect the current structure of basic_json.

In 5a1a575 the underlying structure of
basic_json was altered to move m_type and m_value under an m_data field.
This updates the nativ template to be consistent with this change.

* Generate nlohmann_json.natvis for 3.11.3 and latest basic_json structure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants