-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSVC 2015 update 2 #469
Comments
I do not know. We use MSVC 19.0.24215.1 in the unit tests on AppVeyor (see https://ci.appveyor.com/project/nlohmann/json for the latest build result). Did you try? What error message did you get? |
Hi, my colleague Pooyan Dadvant will be posting the error. |
Just to share the error I got while compiling it with my VS build 14.023107.0 1>C:\Kratos\external_libraries\json/json.hpp(887): error C4579: 'nlohmann::detail::static_constnlohmann::detail::to_json_fn::value': in-class initialization for type 'const T' is not yet implemented; static member will remain uninitialized at runtime but use in constant-expressions is supported |
Thanks. Could you compile the unit tests? |
I have try to compile the unit testing with a clone of the current repository version and gives me the same compilation error. |
Could you please post the error from compiling the unit tests as well, because then we have the complete picture where the error first occurs. Well, I am no expert in MSVC. It seems as if AppVeyor is using a slightly more modern version (just comparing the build version numbers). Is that Update 3? |
The update 3 is more modern but it is incompatible with boost library which we are using.... |
here you have the output:
|
@theodelrieu Any idea on this? MSVC seems to have an issue with |
I don't know if there is a workaround to that... You could also try to replace |
@pooyan-dadvand Did you try the hack proposed by @theodelrieu?
|
Not yet... l will do it ASAP! |
It did not compiled claiming that the expression is not constant. The error:
|
@pooyan-dadvand This is a pity, but I think we cannot help you right now. |
Hi Niels, shame to hear this. |
@RiccardoRossi are you talking about the |
Yes
El 5 mar. 2017 6:12 p. m., "Théo DELRIEU" <notifications@github.com>
escribió:
… @RiccardoRossi <https://github.com/RiccardoRossi> are you talking about
the static_const?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#469 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AHr7Eboqi-uxkzahU9BvgfDZEefP43maks5riuz1gaJpZM4MKLeg>
.
|
Well, it's not gonna help, if I remember correctly, the point of being a reference in an anonymous namespace is to prevent ODR-violation. You can read this Eric Niebler's blog post to know the very details (I don't remember all of them) I hope the next MSVC release will solve your Boost.Python problems |
Hope so! Time will solve everything, even MSVC problems! Thanks. |
I close this issue here as there is nothing we can do. @RiccardoRossi @pooyan-dadvand it would be great if you could give us feedback whether this issue eventually was resolved. |
Hi Niels, in any case thank you for your time and effort. |
vs community 2015 run ok! |
Good news! Thanks for notification! @RiccardoRossi we should give it another try then |
@mjrao I am not using MSVC myself. Is "vs community 2015" something different than "msvc2015"? |
Visual Studio Community 2015 is the same as Visual Studio Professional 2015 but with a different license. |
Thanks for the info. So I can keep the README as is, because there is no additional supported compiler or version. |
@nlohmann Thanks for your reply! Compile failed in VS 2015 Enterprise and VS 2015 Professional, but compiled successfully in VS 2015 Community. I don't know what happened. Compile error is as follows: |
Can you try the |
@mjrao Are you sure you're using the same update version and compiler settings in both? Sounds like either the community version is a more recent update, or the warning settings are different. |
VS 2015 Community Vesion: 14.0.25420.01 Update 3 @gregmarr |
Hi ,I meet the problem in vs2015 :C2440,cannot convert from 'initializer-list' to nlohmann::basic_json ,is anyone know how to solve this? |
Hi Everyone, I am trying this library by following all the steps as mentioned by including json.hpp in my project. Here I am also getting the same problem with the following error message.
I am using vs 2015 Pro with Platform Toolset : Visual Studio 2015 (v140). Thanks in advance |
use VS 2015 Community. or try vs2019 ? |
Thanks @mjrao for your reply. Actually in my organization we only have this version of VS subscription it will take time for them to upgrade this but because I need some solution urgently I have now used RapidJSON. I think this is because of old c++ compiler version. Will try this in latest VS as you mentioned I am sure it will work. |
Hello,
i wanted to know if there is any possibility of using the library with visual studio 2015 UPDATE 2.
Think is that update 3 is not viable for us, since boost.python is broken.
regards
Riccardo
The text was updated successfully, but these errors were encountered: