Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Container function overview in Doxygen is not updated #883

Closed
pravic opened this issue Dec 18, 2017 · 2 comments
Closed

Container function overview in Doxygen is not updated #883

pravic opened this issue Dec 18, 2017 · 2 comments
Assignees
@nlohmann
Labels
confirmed documentation solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Milestone
Release 3.0.1

Comments

@pravic
Copy link

pravic commented Dec 18, 2017 •
edited
Loading

Bug Report

  • What is the issue you have?
    Outdated documentation.

  • Please describe the steps to reproduce the issue. Can you provide a small but working code example?
    Check https://nlohmann.github.io/json/

  • What is the expected behavior?
    json::parse_error instead of std::domain_error and so on.

  • And what is the actual behavior instead?
    We see old exception types still.

  • Did you use a released version of the library or the version from the develop branch?
    Documentation says it is version 3.0.0.

P.S. 3.0 is a huge and exciting work, actually.
@nlohmann nlohmann added this to the Release 3.0.1 milestone Dec 18, 2017
@nlohmann nlohmann self-assigned this Dec 18, 2017
@nlohmann
Copy link
Owner

Thanks for reporting! This was an oversight.

nlohmann added a commit that referenced this issue Dec 18, 2017
@nlohmann
📝 fix for #883
88ddb12 
- Adjusted table to user-defined exceptions. This was forgotten in the 3.0.0 update.
- Added update function to the table.
@nlohmann nlohmann added the solution: proposed fix a fix for the issue has been proposed and waits for confirmation label Dec 18, 2017
@nlohmann
Copy link
Owner

Fixed:

table

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nlohmann nlohmann

Labels
confirmed documentation solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Projects
None yet
Milestone
Release 3.0.1
Development

No branches or pull requests
2 participants
@nlohmann @pravic