Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move class json_pointer to separate file #920

Closed
nlohmann opened this issue Jan 17, 2018 · 1 comment
Closed

Move class json_pointer to separate file #920

nlohmann opened this issue Jan 17, 2018 · 1 comment
Assignees
@nlohmann
Labels
solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Milestone
Release 3.1.0

Comments

@nlohmann
Copy link
Owner

Class json_pointer is spread around file json.hpp. It should be moved into a separate file in the develop folder and included just like the other sub-classes.
@theodelrieu
Copy link
Contributor

I did try to do so but had to revert my changes, although I don't remember why.

I'll try again, I probably missed something.

@nlohmann nlohmann self-assigned this Jan 28, 2018
@nlohmann nlohmann added this to the Release 3.1.0 milestone Jan 28, 2018
@nlohmann nlohmann added the solution: proposed fix a fix for the issue has been proposed and waits for confirmation label Jan 28, 2018
nlohmann added a commit that referenced this issue Jan 28, 2018
@nlohmann
🔨 moved class json_pointer into separate file #920
1483d39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nlohmann nlohmann

Labels
solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Projects
None yet
Milestone
Release 3.1.0
Development

No branches or pull requests
2 participants
@nlohmann @theodelrieu