Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split headers should be part of the release #956

Closed
theodelrieu opened this issue Feb 4, 2018 · 6 comments
Closed

Split headers should be part of the release #956

theodelrieu opened this issue Feb 4, 2018 · 6 comments
Assignees
@nlohmann
Labels
solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Milestone
Release 3.1.0

Comments

@theodelrieu
Copy link
Contributor

Currently, only the amalgamated json.hpp file and the entire repository source code (over 100MB) are available in the Releases tab.

It would help a lot to add a zip archive containing the include directory as well, especially for package managers which have to fully clone the repository if not installing the amalgamated version.
@nlohmann
Copy link
Owner

nlohmann commented Feb 4, 2018

I agree.

@nlohmann nlohmann self-assigned this Feb 4, 2018
@pboettch
Copy link
Contributor

pboettch commented Feb 4, 2018

I like the idea of @astoeckel, having a read-only-header-file-release-repo. I'd use that as a sub-module. #96 (comment)

@nlohmann
Copy link
Owner

nlohmann commented Feb 4, 2018

Let's see if this works better than #96 (comment) :)

@nlohmann
Copy link
Owner

nlohmann commented Feb 4, 2018

Fixed:

release

@nlohmann nlohmann closed this as completed Feb 4, 2018
@nlohmann nlohmann added the solution: proposed fix a fix for the issue has been proposed and waits for confirmation label Feb 4, 2018
nlohmann added a commit that referenced this issue Feb 4, 2018
@nlohmann
🚀 added release target #956
2b7b39c
@pboettch
Copy link
Contributor

pboettch commented Feb 4, 2018

Yeah, in the long run it would be safer if you'd semi-automatically maintain such a repo I guess.

@theodelrieu
Copy link
Contributor Author

Great! Could you add the SHA-256 for the include.zip as well?

@nlohmann nlohmann added this to the Release 3.1.0 milestone May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nlohmann nlohmann

Labels
solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Projects
None yet
Milestone
Release 3.1.0
Development

No branches or pull requests
3 participants
@nlohmann @pboettch @theodelrieu