Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc cmake packaging enhancements #1048

Merged
merged 2 commits into from
Apr 10, 2018
Merged

Misc cmake packaging enhancements #1048

merged 2 commits into from
Apr 10, 2018

Conversation

chuckatkins
Copy link
Contributor

Some additions to the CMake package configs to be more consistent with common CMake packaging guidelines:

  • Use namespaces for imported targets
  • Allow package configs in build directory
  • User-defined install location for package configs

Chuck Atkins added 2 commits April 9, 2018 11:31
Make the CMake install dir user-configurable
031b88d
Enable target namespaces and build dir project config
33a2154 
CMake convention is to use a project namespace, i.e. Foo::, for imported
targets.  When multiple targets are imported from a project, this looks
like Foo::Bar1 Foo::Bar2, etc.  This adds the nlohmann_json:: namespace to
the exported target names.

This also allows the generated project config files to be used from the
build directory instead of just the install directory.
@chuckatkins chuckatkins mentioned this pull request Apr 10, 2018
Closed
2 tasks
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 33a2154 on chuckatkins:misc-cmake-packaging-enhancements into 29362c6 on nlohmann:develop.

nlohmann
nlohmann approved these changes Apr 10, 2018
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this Apr 10, 2018
@nlohmann nlohmann added this to the Release 3.1.3 milestone Apr 10, 2018
@nlohmann nlohmann merged commit b8bfd11 into nlohmann:develop Apr 10, 2018
@nlohmann
Copy link
Owner

Thanks a lot!

This was referenced Aug 12, 2018
Closed
Merged
@nlohmann nlohmann mentioned this pull request Sep 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees

@nlohmann nlohmann

Labels
None yet
Projects
None yet
Milestone
Release 3.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@chuckatkins @coveralls @nlohmann