fixed compile error for #1045 #1134
Conversation
|
@nlohmann I don't understand why Codacy didn't work, I did retry but still no luck |
|
Ignore Codacity for the moment. I am on holidays right now and shall have a look at this soon. |
|
@nlohmann any update? |
|
Sorry for the delay. I’ll check tomorrow or Wednesday at latest. |
|
Looks good, but could you make a PR for |
|
I changed it to develop, or did you mean I should create a new one? |
| void to_json(BasicJsonType& j, T b) noexcept | ||
| { | ||
| typename BasicJsonType::object_t tmp_obj; | ||
| tmp_obj[b.key()] = b.value(); // TODO: maybe there is a better way? |
There was a problem hiding this comment.
I'll have a look at this later.
| void to_json(BasicJsonType& j, T b) noexcept | ||
| { | ||
| typename BasicJsonType::object_t tmp_obj; | ||
| tmp_obj[b.key()] = b.value(); // TODO: maybe there is a better way? |
There was a problem hiding this comment.
I'll have a look at this later.
|
I solved the TODOs. Thanks so much for the PR! |
|
No problem 😁 |
|
i get compile error in vs2015 sp1: 1>d:\xxxxxx\json.h(2599): error C2100: 非法的间接寻址 (编译源文件 D:\xxxx.cpp) hope can fix this compile error. |
|
@mnzn2530 Please create an issue for this. |
#1045
Added
to_json(BasicJsonType, iteration_proxy_internal)which was needed.note: there are 2 TODOs to consider