-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/unordered map conversion #1138
Feature/unordered map conversion #1138
Conversation
1a9d681
to
f8a265d
Compare
Weird that the single header contains things that aren't part of your PR. I guess someone committed to develop without running |
LGTM |
f8a265d
to
42247f8
Compare
42247f8
to
2c920a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Thanks @theodelrieu for the PR and @gregmarr for the review! |
When can we expect the dev branch to merge with master branch? I use vcpkg to install this library -- is there a way to get dev branch using vcpkg? |
I hope to release version 3.1.3 before end of July. |
Add conversion for
std::unordered_map
, whenKeyType != basic_json<>::string_t
Fixes #1133
Pull request checklist
Read the Contribution Guidelines for detailed information.
include/nlohmann
directory, runmake amalgamate
to create the single-header filesingle_include/nlohmann/json.hpp
. The whole process is described here.