Overload parse() to accept an rvalue reference #120
Merged
+5
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, one cannot directly pass a
std::ifstream
to theparse
function:This fails with the error:
If I'm not mistaken, this happens because a temporary
ifstream
is created which cannot be bound to a non-const reference, as it's required from the signature ofparse(std::istream&, parser_callback_t)
.Overloading
parse
to accept an rvalue reference (valid C++11) solves the problem and allows to move the ownership of the temporary stream to the function.