Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1179 Reordered the code. It seems to stop clang 3.4.2 in RHEL 7 from crash… #1249

Merged
merged 1 commit into from
Sep 22, 2018

Conversation

LEgregius
Copy link

@LEgregius LEgregius commented Sep 19, 2018

Closes #1179.

#1179 I moved code around a bit because the swap specialization. I tried running the tests, but they wouldn't compile and link due to some issues with the way the libraries are linked on RHEL 7. I can try it on another computer if issues arise, but since there shouldn't be any change in functionality because code was simply moved around, I don't expect there to be any problems with tests.

@LEgregius LEgregius changed the title Reordered the code. It seems to stop clang 3.4.2 in RHEL 7 from crash… #1179 Reordered the code. It seems to stop clang 3.4.2 in RHEL 7 from crash… Sep 19, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 4d780b0 on LEgregius:clang-3.4.2-crash-workaround into e4bc98d on nlohmann:develop.

@nlohmann nlohmann added this to the Release 3.2.1 milestone Sep 22, 2018
@nlohmann nlohmann self-assigned this Sep 22, 2018
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann merged commit 88b055c into nlohmann:develop Sep 22, 2018
@nlohmann
Copy link
Owner

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants