Fix broken cmake imported target alias #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuckatkins
force-pushed
the
fix-cmake-target-alias
branch
3 times, most recently
from
08e03ac
to
00a63a8
Compare
chuckatkins
changed the title
chuckatkins
force-pushed
the
fix-cmake-target-alias
branch
from
00a63a8
to
ea9ea94
Compare
|
There are test cases failing for the Linux builds. @chuckatkins |
|
Just saw that. I'll fix it today. That's great though, it means the tests are doing what they're supposed to be doing! |
|
I'm looking forward to having this issue fixed - I could then make the next release. |
4 tasks
chuckatkins
force-pushed
the
fix-cmake-target-alias
branch
from
ea9ea94
to
fb246de
Compare
|
@nlohmann This should be good to go now |
chuckatkins
force-pushed
the
fix-cmake-target-alias
branch
from
fb246de
to
02e653b
Compare
|
Thanks for the fix! |
nlohmann
referenced
this pull request
Oct 1, 2018
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup on #1245 in which the fix caused additional breakage. This PR does a more complete implementation of the package configs with version checking. It also adds a set of tests to make sure that other CMake projects can import and use the package config.