docs: Add additional CMake documentation #1270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuckatkins
force-pushed
the
add-more-cmake-docs
branch
6 times, most recently
from
9803008
to
dae12d6
Compare
nlohmann
requested changes
Oct 2, 2018
README.md
Outdated
| @@ -16,6 +16,10 @@ | |||
|
|
|||
| - [Design goals](#design-goals) | |||
| - [Integration](#integration) | |||
| - [CMake](#cmake) | |||
| - [External](#external) | |||
| - [Embedded](#embedded) | |||
There was a problem hiding this comment.
The table of contents seems to be rather crowded.
- Please leave "External", "Embedded", and "Supporting Both" out of the table of contents.
- Please add "Package Managers" to the table of contents.
chuckatkins
force-pushed
the
add-more-cmake-docs
branch
from
dae12d6
to
a04ac2c
Compare
|
@nlohmann TOC fixed and cleaned up. |
nlohmann
requested changes
Oct 2, 2018
|
Looks like Travis got a little borked. I'll kick the branch to cycle the CI again. |
chuckatkins
force-pushed
the
add-more-cmake-docs
branch
from
a04ac2c
to
afa22d9
Compare
chuckatkins
force-pushed
the
add-more-cmake-docs
branch
from
afa22d9
to
4c61761
Compare
|
@nlohmann this should be good too go now to once CI finishes. |
nlohmann
approved these changes
Oct 3, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some additional documentation for how to integrate this into another CMake project.