Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed linter warnings #1280

Merged
merged 6 commits into from
Oct 8, 2018
Merged

Removed linter warnings #1280

merged 6 commits into from
Oct 8, 2018

Conversation

nlohmann
Copy link
Owner

@nlohmann nlohmann commented Oct 6, 2018

Removed some linter warnings from clang-analize, coverity, and lgtm.

@nlohmann
Copy link
Owner Author

nlohmann commented Oct 6, 2018

This pull request fixes 1 alert when merging fa722d5 into ac38e95 - view on LGTM.com

fixed alerts:

  • 1 for Comparison result is always the same

Comment posted by LGTM.com

@coveralls
Copy link

coveralls commented Oct 6, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 6d34d64 on feature/linter into ac38e95 on develop.

@nlohmann
Copy link
Owner Author

nlohmann commented Oct 7, 2018

This pull request fixes 1 alert when merging 3abb788 into ac38e95 - view on LGTM.com

fixed alerts:

  • 1 for Comparison result is always the same

Comment posted by LGTM.com

@nlohmann
Copy link
Owner Author

nlohmann commented Oct 7, 2018

This pull request fixes 1 alert when merging 6e49d9f into ac38e95 - view on LGTM.com

fixed alerts:

  • 1 for Comparison result is always the same

Comment posted by LGTM.com

@nlohmann
Copy link
Owner Author

nlohmann commented Oct 8, 2018

This pull request fixes 1 alert when merging 6d34d64 into ac38e95 - view on LGTM.com

fixed alerts:

  • 1 for Comparison result is always the same

Comment posted by LGTM.com

@nlohmann nlohmann self-assigned this Oct 8, 2018
@nlohmann nlohmann added this to the Release 3.3.1 milestone Oct 8, 2018
@nlohmann nlohmann merged commit adfa961 into develop Oct 8, 2018
@nlohmann nlohmann deleted the feature/linter branch October 8, 2018 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants