Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add constraints for variadic json_ref constructors #1294

Merged
merged 1 commit into from
Oct 12, 2018
Merged

add constraints for variadic json_ref constructors #1294

merged 1 commit into from
Oct 12, 2018

Conversation

theodelrieu
Copy link
Contributor

@theodelrieu theodelrieu commented Oct 12, 2018 •
edited
Loading

Fixes #1292

Pull request checklist

Read the Contribution Guidelines for detailed information.

  • Changes are described in the pull request, or an existing issue is referenced.
  • The test suite compiles and runs without error.
  • Code coverage is 100%. Test cases can be added by editing the test suite.
  • The source code is amalgamated; that is, after making changes to the sources in the include/nlohmann directory, run make amalgamate to create the single-header file single_include/nlohmann/json.hpp. The whole process is described here.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 11fecc2 on theodelrieu:fix/json_ref_ctor into e426219 on nlohmann:develop.

nlohmann
nlohmann approved these changes Oct 12, 2018
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this Oct 12, 2018
@nlohmann nlohmann added this to the Release 3.3.1 milestone Oct 12, 2018
@nlohmann nlohmann merged commit dd67293 into nlohmann:develop Oct 12, 2018
@nlohmann nlohmann mentioned this pull request Oct 12, 2018
Closed
@nlohmann
Copy link
Owner

Thanks!

@theodelrieu theodelrieu deleted the fix/json_ref_ctor branch October 12, 2018 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees

@nlohmann nlohmann

Labels
release item: 🐛 bug fix
Projects
None yet
Milestone
Release 3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@theodelrieu @coveralls @nlohmann