Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix EOL Whitespaces & CMake Spelling #1329

Merged
merged 2 commits into from
Nov 2, 2018
Merged

Fix EOL Whitespaces & CMake Spelling #1329

merged 2 commits into from
Nov 2, 2018

Conversation

ax3l
Copy link
Contributor

@ax3l ax3l commented Nov 2, 2018 •
edited
Loading

Fix little leftover EOL whitespaces in CMakeLists.txt and a spelling of CMake in README.md.
Second commit: remove EOL whitespaces in natvis file.

Pull request checklist

Read the Contribution Guidelines for detailed information.

  • Changes are described in the pull request.
  • The test suite compiles and runs without error.
  • (unchanged) Code coverage is 100%. Test cases can be added by editing the test suite.
  • (unaffected) The source code is amalgamated; that is, after making changes to the sources in the include/nlohmann directory, run make amalgamate to create the single-header file single_include/nlohmann/json.hpp. The whole process is described here.

@ax3l
Fix EOL Whitespaces & CMake Spelling
689382a 
Fix little leftover EOL whitespaces in `CMakeLists.txt` and
a spelling of CMake in README.md
nlohmann
nlohmann approved these changes Nov 2, 2018
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann added this to the Release 3.4.1 milestone Nov 2, 2018
@nlohmann nlohmann self-assigned this Nov 2, 2018
@coveralls
Copy link

coveralls commented Nov 2, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling a7567bc on ax3l:fix-typosWhitespaces into 2f73a4d on nlohmann:develop.

@nlohmann nlohmann merged commit d2e6e1b into nlohmann:develop Nov 2, 2018
@nlohmann
Copy link
Owner

nlohmann commented Nov 2, 2018

Thanks!

@ax3l ax3l deleted the fix-typosWhitespaces branch November 5, 2018 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees

@nlohmann nlohmann

Labels
release item: 🔨 further change
Projects
None yet
Milestone
Release 3.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ax3l @coveralls @nlohmann