Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions about using nlohmann/json with the conda package manager #1430

Merged
merged 1 commit into from
Jan 15, 2019

Conversation

nicoddemus
Copy link
Contributor

No description provided.

README.md Outdated Show resolved Hide resolved
@nlohmann
Copy link
Owner

Thanks for the PR. I have two questions:

  • Can you please provide an example of the required steps to compile a simple hello-world program using the library and conda? I do not use package managers myself, so it's hard for me to understand how easy the integration is. This should not go into the README - an example for me is sufficient as I am overworking the website where I shall have more space to discuss the different package managers.
  • Does the page automatically use the most recent version of the library or is a manual step required? I am asking because I need to know if I need to notify in case of a new release.

@coveralls
Copy link

coveralls commented Jan 14, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling b025d66 on nicoddemus:conda-docs into e5753b1 on nlohmann:develop.

@tadeu
Copy link

tadeu commented Jan 15, 2019

Hi @nicoddemus and @nlohmann, I've created a short example of the required steps to compile a simple hello-world program using the library and conda, it's here: https://github.com/tadeu/hello_json/

@nicoddemus
Copy link
Contributor Author

Cool, thanks @tadeu

@nicoddemus
Copy link
Contributor Author

Does the page automatically use the most recent version of the library or is a manual step required? I am asking because I need to know if I need to notify in case of a new release.

conda-forge has a bot which automatically updates the package within a few hours after a new release, so no notification from your part will be necessary. 👍

Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this Jan 15, 2019
@nlohmann nlohmann added this to the Release 3.5.1 milestone Jan 15, 2019
@nlohmann nlohmann merged commit 851fe8a into nlohmann:develop Jan 15, 2019
@nlohmann
Copy link
Owner

Thanks a lot!

@nicoddemus
Copy link
Contributor Author

Awesome, thanks!

@nicoddemus nicoddemus deleted the conda-docs branch January 15, 2019 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants