Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package Manager: MSYS2 (pacman) #1670

Merged
merged 1 commit into from
Jul 13, 2019
Merged

Package Manager: MSYS2 (pacman) #1670

merged 1 commit into from
Jul 13, 2019

Conversation

podsvirov
Copy link
Contributor

Add a package installation instructions for MSYS2 software distro.

I contributed a package to the MSYS2 software distro.

Just type pacman -S mingw-w64-i686-nlohmann_json or pacman -S mingw-w64-x86_64-nlohmann_json for installation.

@podsvirov
Package Manager: MSYS2 (pacman)
6a3cdb2 
Add a package installation instructions for MSYS2 software distro.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 6a3cdb2 on podsvirov:readme-package-managers-msys2 into b17440c on nlohmann:develop.

nlohmann
nlohmann approved these changes Jul 13, 2019
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this Jul 13, 2019
@nlohmann nlohmann added this to the Release 3.7.0 milestone Jul 13, 2019
@nlohmann
Copy link
Owner

🔖 Release item

This issue/PR will be part of the next release of the library. This template helps preparing the release notes.

Type

  • ✨ New Feature
  • 🐛 Bug Fix
  • ⚡️ Improvement
  • 🔨 Further Change
  • 🔥 Deprecated function

Description

@podsvirov
Copy link
Contributor Author

I apologize, but I don’t quite understand: should I do something else to accept these changes?

@nlohmann
Copy link
Owner

I was just waiting for the CI to complete.

@nlohmann nlohmann merged commit 8d059b9 into nlohmann:develop Jul 13, 2019
@nlohmann
Copy link
Owner

Thanks a lot!!!

@podsvirov
Copy link
Contributor Author

Thanks a lot!!!

Thank you too! ;-)

@podsvirov podsvirov deleted the readme-package-managers-msys2 branch July 13, 2019 16:17
@t-b t-b mentioned this pull request Aug 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees

@nlohmann nlohmann

Labels
release item: ✨ new feature
Projects
None yet
Milestone
Release 3.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@podsvirov @coveralls @nlohmann