Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

did you mean 'serialization'? #1767

Merged
merged 1 commit into from
Oct 1, 2019
Merged

did you mean 'serialization'? #1767

merged 1 commit into from
Oct 1, 2019

Conversation

0xflotus
Copy link
Contributor

I only fixed a typo

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling d7579b8 on 0xflotus:patch-1 into 99d7518 on nlohmann:develop.

@jaredgrubb
Copy link
Contributor

+1 pretty simple change, thanks!

@nlohmann nlohmann self-assigned this Oct 1, 2019
@nlohmann nlohmann added this to the Release 3.7.1 milestone Oct 1, 2019
nlohmann
nlohmann approved these changes Oct 1, 2019
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann merged commit d826282 into nlohmann:develop Oct 1, 2019
@nlohmann
Copy link
Owner

nlohmann commented Oct 1, 2019

Thanks!

@nlohmann
Copy link
Owner

nlohmann commented Oct 1, 2019

🔖 Release item

This issue/PR will be part of the next release of the library. This template helps preparing the release notes.

Type

  • ✨ New Feature
  • 🐛 Bug Fix
  • ⚡️ Improvement
  • 🔨 Further Change
  • 🔥 Deprecated function

Description

  • Fixed a typo in the README.

@0xflotus 0xflotus deleted the patch-1 branch October 1, 2019 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees

@nlohmann nlohmann

Labels
release item: 🔨 further change
Projects
None yet
Milestone
Release 3.7.1
Development

Successfully merging this pull request may close these issues.
4 participants
@0xflotus @coveralls @jaredgrubb @nlohmann