Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/CMakeLists.txt: Use an explicit list instead of GLOB #1779

Merged
merged 1 commit into from
Oct 9, 2019
Merged

test/CMakeLists.txt: Use an explicit list instead of GLOB #1779

merged 1 commit into from
Oct 9, 2019

Commits on Oct 7, 2019

  1. test/CMakeLists.txt: Use an explicit list instead of GLOB 

    Using GLOB is slow and considered bad practice.

From https://cmake.org/cmake/help/latest/command/file.html:

> We do not recommend using GLOB to collect a list of source files from
> your source tree. If no CMakeLists.txt file changes when a source is
> added or removed then the generated build system cannot know when to ask
> CMake to regenerate. The CONFIGURE_DEPENDS flag may not work reliably on
> all generators, or if a new generator is added in the future that cannot
> support it, projects using it will be stuck. Even if CONFIGURE_DEPENDS
> works reliably, there is still a cost to perform the check on every
> rebuild.
    @t-b
    t-b committed Oct 7, 2019
    Configuration menu
    Copy the full SHA
    eb6fe42 View commit details
    Browse the repository at this point in the history