Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iteration_proxy: Fix integer truncation from std::size_t to int #1797

Merged
merged 1 commit into from
Oct 17, 2019
Merged

iteration_proxy: Fix integer truncation from std::size_t to int #1797

merged 1 commit into from
Oct 17, 2019

Conversation

t-b
Copy link
Contributor

@t-b t-b commented Oct 16, 2019

Bug introduced in 0f073e2 (Allow items() to be used with custom string,
2019-09-26).

@crazyjul FYI.

See also #1765.

@t-b
iteration_proxy: Fix integer truncation from std::size_t to int
35b47c2 
Bug introduced in 0f073e2 (Allow items() to be used with custom string,
2019-09-26).
@t-b t-b mentioned this pull request Oct 16, 2019
Closed
@crazyjul
Copy link
Contributor

Looks good to me 👍

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 35b47c2 on t-b:fix-integer-truncation into ed55414 on nlohmann:develop.

nlohmann
nlohmann approved these changes Oct 17, 2019
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this Oct 17, 2019
@nlohmann nlohmann added this to the Release 3.7.1 milestone Oct 17, 2019
@nlohmann nlohmann merged commit 0245ae5 into nlohmann:develop Oct 17, 2019
@nlohmann
Copy link
Owner

Thanks!

@nlohmann
Copy link
Owner

🔖 Release item

This issue/PR will be part of the next release of the library. This template helps preparing the release notes.

Type

  • ✨ New Feature
  • 🐛 Bug Fix
  • ⚡️ Improvement
  • 🔨 Further Change
  • 🔥 Deprecated function

Description

  • Fixed an integer truncation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees

@nlohmann nlohmann

Labels
release item: 🔨 further change
Projects
None yet
Milestone
Release 3.7.1
Development

Successfully merging this pull request may close these issues.
4 participants
@t-b @crazyjul @coveralls @nlohmann