Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add restriction for tuple specialization of to_json #1826

Merged
merged 1 commit into from
Nov 5, 2019
Merged

Add restriction for tuple specialization of to_json #1826

merged 1 commit into from
Nov 5, 2019

Conversation

cbegue
Copy link
Contributor

@cbegue cbegue commented Nov 4, 2019

This PR fix the issue #1825

Add restriction for tuple specialization of to_json
8b686b3 
This commit fix the issue #1825

Signed-off-by: Camille Bégué <c.begue@samsung.com>
@cbegue cbegue requested a review from nlohmann as a code owner November 4, 2019 09:20
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 8b686b3 on cbegue:develop into 3790bd9 on nlohmann:develop.

nlohmann
nlohmann approved these changes Nov 5, 2019
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this Nov 5, 2019
@nlohmann nlohmann added this to the Release 3.7.1 milestone Nov 5, 2019
@nlohmann nlohmann merged commit 1ca6f29 into nlohmann:develop Nov 5, 2019
@nlohmann
Copy link
Owner

nlohmann commented Nov 5, 2019

Thanks!

@nlohmann nlohmann mentioned this pull request Nov 5, 2019
Closed
@nlohmann
Copy link
Owner

nlohmann commented Nov 5, 2019 •
edited
Loading

🔖 Release item

This issue/PR will be part of the next release of the library. This template helps preparing the release notes.

Type

  • ✨ New Feature
  • 🐛 Bug Fix
  • ⚡️ Improvement
  • 🔨 Further Change
  • 🔥 Deprecated function

Description

  • Add restriction for tuple specialization of to_json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees

@nlohmann nlohmann

Labels
release item: 🐛 bug fix
Projects
None yet
Milestone
Release 3.7.1
Development

Successfully merging this pull request may close these issues.
3 participants
@cbegue @coveralls @nlohmann