-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split test-unicode to avoid timeouts #1884
Conversation
What do you think of this simple re-organization for test-unicode to partition its running time that could help fix issues like #1816 and #1032. The pipeline has falied due to (ironically) exceeding Appveyor 1 hour limit. A re-run might fix that. I've also tried to some micro-optimizations on implementation of |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@nickaein I think this PR is a good try. We can reopen this one to solve the problem. |
@dota17 Can you test this branch locally to see whether it is effective in your case? https://github.com/nickaein/nlohmann-json/tree/fix/split-unicode-tests |
Can you please update to the latest |
Everything is fine in my local env. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This PR splits the long-running
unit-test_all
into two standalone unit-tests.Fixes #1816, fixes #1032 (hopefully).
Pull request checklist
Read the Contribution Guidelines for detailed information.
include/nlohmann
directory, runmake amalgamate
to create the single-header filesingle_include/nlohmann/json.hpp
. The whole process is described here.Please don't
#ifdef
s or other means.