Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #195 - update Travis to Trusty due to gcc/clang strtod() bug #196

Merged
merged 2 commits into from
Jan 26, 2016

Conversation

twelsby
Copy link
Contributor

@twelsby twelsby commented Jan 25, 2016

This pull request updates Travis to use the Ubuntu Trusty distribution instead of Precise. This is required due to the bug in strtod() that is uncorrected in Precise builds of the standard library but fixed in Trusty. This bug causes a single bit rounding error that may occur in as many as 1 in 4096 of the possible double values.

Note that currently this PR still uses the llvm-toolchain-precise* repositories because the llvm-toolchain-trusty* ones have not been added to the Travis white-list. This works because clang is not the problem, rather it is the standard library.

There is an open issue on Travis APT source whitelist request for llvm-toolchain-trusty #199 to add the repositories to the white-list at which point .travis.yml can be further updated. It is suggested that perhaps this pull be merged but issue #195 be left open until the trusty llvm repos can be added as well.

@nlohmann nlohmann added this to the Release 2.0.0 milestone Jan 26, 2016
nlohmann added a commit that referenced this pull request Jan 26, 2016
Issue #195 - update Travis to Trusty due to gcc/clang strtod() bug
@nlohmann nlohmann merged commit 077fb1d into nlohmann:master Jan 26, 2016
nlohmann added a commit that referenced this pull request Jan 26, 2016
@nlohmann
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants