Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue#1972 #2153

Merged
merged 2 commits into from
Jun 3, 2020
Merged

Fix issue#1972 #2153

merged 2 commits into from
Jun 3, 2020

Conversation

dota17
Copy link
Contributor

@dota17 dota17 commented May 30, 2020

Fix issue #1972

In order to delete discarded value when the parsed value is like [1, <discarded>] in end_object() function, we should check if ref_stack.back() is array or is object, so we should replace ref_stack.back()->is_object() with ref_stack.back()->is_structured().

@dota17 dota17 requested a review from nlohmann as a code owner May 30, 2020 09:59
@coveralls
Copy link

coveralls commented May 30, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 8cd3957 on dota17:issue#1972 into 53ef076 on nlohmann:develop.

@FrancoisChabot
Copy link
Contributor

This PR should contain a unit test that fails with the current implementation, and is fixed by your change.

nlohmann
nlohmann approved these changes Jun 3, 2020
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann linked an issue Jun 3, 2020 that may be closed by this pull request
Unclear docs regarding parser_callback_t callbacks #1972
Closed
@nlohmann nlohmann self-assigned this Jun 3, 2020
@nlohmann nlohmann added this to the Release 3.8.0 milestone Jun 3, 2020
@nlohmann nlohmann merged commit 309acb4 into nlohmann:develop Jun 3, 2020
@nlohmann
Copy link
Owner

nlohmann commented Jun 3, 2020

Thanks a lot!!!

@nlohmann
Copy link
Owner

nlohmann commented Jun 3, 2020

🔖 Release item

This issue/PR will be part of the next release of the library. This template helps preparing the release notes.

Type

  • ✨ New Feature
  • 🐛 Bug Fix
  • ⚡️ Improvement
  • 🔨 Further Change
  • 🔥 Deprecated function

Description

@dota17 dota17 deleted the issue#1972 branch June 3, 2020 10:28
@laomaiweng
Copy link

Thank you all. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees

@nlohmann nlohmann

Labels
release item: 🐛 bug fix
Projects
None yet
Milestone
Release 3.8.0
Development

Successfully merging this pull request may close these issues.

Unclear docs regarding parser_callback_t callbacks
5 participants
@dota17 @coveralls @FrancoisChabot @nlohmann @laomaiweng