Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unused parameter #2299

Merged
merged 1 commit into from
Jul 22, 2020
Merged

Fix unused parameter #2299

merged 1 commit into from
Jul 22, 2020

Conversation

nlohmann
Copy link
Owner

This PR fixes the issue detected in #2298: parameter allow_exceptions was not used in a from_cbor function. Furthermore, two other warnings have been fixed.

Closes #2298.

@nlohmann nlohmann self-assigned this Jul 21, 2020
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 8b14c9b on fix_warnings into 8344857 on develop.

@nlohmann nlohmann added this to the Release 3.8.1 milestone Jul 22, 2020
@nlohmann nlohmann merged commit 484029b into develop Jul 22, 2020
@nlohmann nlohmann deleted the fix_warnings branch July 22, 2020 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nlohmann nlohmann

Labels
release item: 🐛 bug fix
Projects
None yet
Milestone
Release 3.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nlohmann @coveralls