-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing erase(first, last) function to ordered_map #3109
Conversation
There is an assertion that only hits on MSVC builds:
As I do not work on Windows, I cannot debug into this problem to get a stack trace. Any help is greatly appreciated! |
Here's the call-stack |
VS seems to be in line with cppreference, at least. |
Seems like if the range being removed is at the end, that requires resetting the |
I added |
Thanks for the help! I will update the PR later on. Very interesting to see that only MSVC debug mode detected this issue! |
I think that this is solely because of the extra debugging information that MSVC debug adds. The |
Yes, I'm aware that this is really pedantic - that's why I would have expected UBSAN or ASAN to detect this. |
Fixes #3108