-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow custom number types to be used #3577
Open
eric-wieser
wants to merge
12
commits into
nlohmann:develop
Choose a base branch
from
eric-wieser:custom-integer-types
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
The previous type traits were not possible to extend with custom types, as attempting to do so is undefined behavior.
0b70d38
to
d585b6e
Compare
It's been too long since I wrote C++...
My 2 cents:
But first and foremost, get #3575 successfully through CI. I vaguely recall an issue with old MSVCs and unions … |
…/json into custom-integer-types
shaischaudhry
approved these changes
Aug 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
std::is_signed<T>
,std::is_integral<T>
type traits do not permit custom types, and extending these is specified as undefined behavior.Using
std::numeric_limits<T>::is_signed
andstd::numeric_limits<T>::is_integral
means that supporting custom types is doable.This includes a test constructing a very simple integer wrapper type.
In a few places, we have to be a little more precise about what the casts mean.
Pull request checklist
Read the Contribution Guidelines for detailed information.
include/nlohmann
directory, runmake amalgamate
to create the single-header filesingle_include/nlohmann/json.hpp
. The whole process is described here.Please don't
#ifdef
s or other means.