Add 'Check amalgamation' workflow #3693
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a workflow that checks if the sources have been amalgamated and leaves a comment directing to the Contribution Guidelines if they are not.
Because commenting on a PR requires write permission, there are two options for implementing this:
ci_test_amalgamation
target.pull_request
to run theci_test_amalgamation
target.workflow_run
to submit the comment.The downside to option 2 is that the workflow submitting the comment will run after the main workflows have mostly been completed. This PR implements option 1.
Because of
pull_request_target
, for security reasons, this workflow won't take effect until merged into the main branch.I've tested the workflow in my fork.
First-time contributors will see this message: falbrechtskirchinger#3 (comment)
Everyone else: falbrechtskirchinger#3 (comment)
The
check_amalgamation.yml
workflow should be excluded from the required checks for merging and enabled for first-time contributors.