-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bazel build support #3709
Add Bazel build support #3709
Conversation
See PR #1606 for a previous attempt that has questions that apply to this PR as well. |
Yes, please add documentation and check the linked PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please add documentation (see https://json.nlohmann.me/integration/package_managers/ or https://json.nlohmann.me/integration/cmake/).
- Please check the discussion at add bazel build #1606.
Change workspace name Fix typo in WORKSPACE name Try to generate Bazel BUILD file via CMake Update README.md Update README.md Update CMakeLists.txt Still trying to get CMake to generte a list of all JSON sourcfiles ... Remove generated source file Can generate a list of all files now... Some progress Update create_bazel_build_file.cmake Delete nlohmann_json.bzl fgd
I have a very clear picture of how this should work and how it should integrate with generating release artifacts, etc. This isn't it. So here's my suggestion @Vertexwahn: If you finish the documentation as requested by Niels here (the relevant files are in |
@falbrechtskirchinger I added a Bazel paragraph to the Integration section. It would be nice if you could work on the CMake code. BTW: The Bazel files need not be installed. I can maintain the manual update of the Bazel files at least for the next 6 months. |
I added to the README as well as the integration documentation a section about Bazel |
I've submitted a PR to your fork with the relevant changes. Please merge and we can continue here. |
Add Bazel build support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor whitespace issues.
Otherwise, looks good to me.
Co-authored-by: Florian Albrechtskirchinger <falbrechtskirchinger@gmail.com>
Co-authored-by: Florian Albrechtskirchinger <falbrechtskirchinger@gmail.com>
Co-authored-by: Florian Albrechtskirchinger <falbrechtskirchinger@gmail.com>
@nlohmann Can it be merged now or is there any further action needed? |
@Vertexwahn He's on vacation. I'm sure this will be merged shortly after he gets back. |
Thanks! |
This PR helps users of the Bazel build system to integrate JSON for Modern C++ in their builds.